Skip to content

Fuse tuple field assignments - #1299

Merged
Frotty merged 1 commit into
masterfrom
codex/lua-tuple-field-assignment
Sep 5, 2026
Merged

Fuse tuple field assignments#1299
Frotty merged 1 commit into
masterfrom
codex/lua-tuple-field-assignment

Conversation

@Frotty

@Frotty Frotty commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • apply scalarized tuple component selection to lvalues as well as reads
  • emit only the selected backing store for direct, nested, member, and read-modify-write assignments
  • retain one-time index evaluation and index-before-RHS ordering
  • leave whole-tuple assignments on the existing all-component path

Verification

  • ./gradlew test --tests "tests.wurstscript.tests.LuaBackendAuditTests.tupleFieldAssignmentsOnlyTouchTheSelectedStorageComponent" --tests "tests.wurstscript.tests.LuaBackendAuditTests.tupleFieldReadsOnlyLoadTheSelectedStorageComponent" --tests "tests.wurstscript.tests.LuaBackendAuditTests.tupleMemberArrayAssignmentCapturesIndex" --tests "tests.wurstscript.tests.LuaBackendAuditTests.tupleAssignmentCapturesLvalueBeforeRhs"
  • ./gradlew test --tests "tests.wurstscript.tests.TupleTests"
  • the new regression failed on the parent commit with discard calls for every unselected backing field, then passed with only the selected stores

Scope

  • no inliner, register-budget, spill fallback, assurance, or arithmetic lowering changes
  • production-map discard counts, spill counts, and grill test remain to be verified in the map repository

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T00:04:15.949782Z 9a42e35 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Frotty
Frotty merged commit 1c9cbf5 into master Sep 5, 2026
3 checks passed
@Frotty
Frotty deleted the codex/lua-tuple-field-assignment branch September 5, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant